Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix n-tv.de extractor, website format has changed #8414

Merged
merged 10 commits into from Nov 11, 2023

Conversation

1100101
Copy link
Contributor

@1100101 1100101 commented Oct 22, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

As the website format has been changed for videos on n-tv.de, the extractor was broken and could not download videos anymore.

Fixes #3179

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 1dbb4bb

Summary

🛠️🆕🧪

Fix and improve ntvde extractor. Use traverse_obj to handle JSON data and add support for new formats. Update test case with new video.

Oh we're the crew of the ntvde extractor
We fix the bugs and we support new factors
We parse the JSON with traverse_obj
And we update the test case with a heave and a ho

Walkthrough

  • Rewrite video extraction and format selection logic for NTV.de (link)
  • Import traverse_obj function from utils module to access nested values in JSON data (link)
  • Update test case with new video file and its md5 and duration values (link, link)
  • Change thumbnail key from html5VideoPoster to poster in yt_dlp/extractor/ntvde.py (link)

@bashonly bashonly added the site-bug Issue with a specific website label Oct 22, 2023
@bashonly bashonly self-requested a review October 22, 2023 19:46
yt_dlp/extractor/ntvde.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ntvde.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ntvde.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ntvde.py Outdated Show resolved Hide resolved
@seproDev seproDev added the pending-fixes PR has had changes requested label Nov 2, 2023
@1100101 1100101 requested a review from seproDev November 4, 2023 22:34
yt_dlp/extractor/ntvde.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ntvde.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ntvde.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ntvde.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ntvde.py Outdated Show resolved Hide resolved
@seproDev seproDev added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Nov 10, 2023
yt_dlp/extractor/ntvde.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ntvde.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ntvde.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ntvde.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ntvde.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ntvde.py Outdated Show resolved Hide resolved
@bashonly bashonly added pending-fixes PR has had changes requested and removed pending-review PR needs a review labels Nov 11, 2023
1100101 and others added 3 commits November 11, 2023 20:49
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@bashonly bashonly removed the pending-fixes PR has had changes requested label Nov 11, 2023
@bashonly bashonly self-assigned this Nov 11, 2023
@bashonly bashonly merged commit 8afd946 into yt-dlp:master Nov 11, 2023
16 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR: [n-tv.de] 23214572: Unable to extract info
3 participants