-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/NeteaseMusic] more metadata #8531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to update the tests with the changes. Also try avoid force pushing, commits will be squashed upon commit, so take as many as like
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
# Conflicts: # yt_dlp/extractor/neteasemusic.py
In the future, run the test, let it fail, and copy the test dict's missing keys/values from the error output. Do not write the download tests by hand |
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Closes yt-dlp#8530 Authored by: LoserFox
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
In the --embed-metadata option, add album title to the file metadata.
Closes #8530
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at d3d3824
Summary
🎵🏷️🛠️
Add more metadata fields to
NetEaseMusicIE
extractor. Use existing helper functions to parse the JSON response from the API and extract fields such asalbum_artist
,album
,thumbnail
andaverage_rating
.Walkthrough
traverse_obj
to access the JSON response and helper functions to convert the values