Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/NeteaseMusic] more metadata #8531

Merged
merged 9 commits into from
Nov 11, 2023
Merged

[ie/NeteaseMusic] more metadata #8531

merged 9 commits into from
Nov 11, 2023

Conversation

LoserFox
Copy link
Contributor

@LoserFox LoserFox commented Nov 5, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

In the --embed-metadata option, add album title to the file metadata.

Closes #8530

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at d3d3824

Summary

🎵🏷️🛠️

Add more metadata fields to NetEaseMusicIE extractor. Use existing helper functions to parse the JSON response from the API and extract fields such as album_artist, album, thumbnail and average_rating.

NetEaseMusic tracks
More metadata extracted
Winter of content

Walkthrough

  • Add metadata fields for NetEaseMusic tracks (link) by using traverse_obj to access the JSON response and helper functions to convert the values

@seproDev seproDev added the site-enhancement Feature request for some website label Nov 5, 2023
Copy link
Member

@Grub4K Grub4K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update the tests with the changes. Also try avoid force pushing, commits will be squashed upon commit, so take as many as like

yt_dlp/extractor/neteasemusic.py Outdated Show resolved Hide resolved
yt_dlp/extractor/neteasemusic.py Outdated Show resolved Hide resolved
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@bashonly bashonly added the pending-fixes PR has had changes requested label Nov 5, 2023
yt_dlp/extractor/neteasemusic.py Outdated Show resolved Hide resolved
yt_dlp/extractor/neteasemusic.py Outdated Show resolved Hide resolved
yt_dlp/extractor/neteasemusic.py Show resolved Hide resolved
@bashonly
Copy link
Member

bashonly commented Nov 6, 2023

In the future, run the test, let it fail, and copy the test dict's missing keys/values from the error output. Do not write the download tests by hand

Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
@bashonly bashonly added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Nov 6, 2023
@bashonly bashonly self-assigned this Nov 9, 2023
@bashonly bashonly removed the pending-review PR needs a review label Nov 9, 2023
@LoserFox LoserFox requested a review from Grub4K November 11, 2023 11:19
@bashonly bashonly merged commit 46acc41 into yt-dlp:master Nov 11, 2023
16 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NeteaseMusic] add album info into the metadata
4 participants