Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/nebula] Finish Refactor #8566

Merged
merged 27 commits into from Nov 20, 2023
Merged

[ie/nebula] Finish Refactor #8566

merged 27 commits into from Nov 20, 2023

Conversation

seproDev
Copy link
Collaborator

@seproDev seproDev commented Nov 11, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Built on top of #6538 and #6334.
In addition, adds support for classes, cookies, high quality AVC formats, better reauthorization, and updated API endpoints.

Fixes #7588, Fixes #4300, Fixes #5814

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 079920d

Summary

🐛🎓🚀

Add support for Nebula Class and fix archive bug. The pull request introduces a new extractor for NebulaClassIE and allows the _old_archive_ids field to be used in the test helper.

_old_archive_ids
Fixing a bug in archive
Winter of downloads

Walkthrough

  • Add support for Nebula Class platform (link)
  • Fix archive bug for videos with ignored prefixes (link)

@seproDev seproDev added the site-enhancement Feature request for some website label Nov 11, 2023
@bashonly bashonly self-requested a review November 12, 2023 19:53
yt_dlp/extractor/nebula.py Outdated Show resolved Hide resolved
yt_dlp/extractor/nebula.py Outdated Show resolved Hide resolved
yt_dlp/extractor/nebula.py Outdated Show resolved Hide resolved
yt_dlp/extractor/nebula.py Outdated Show resolved Hide resolved
yt_dlp/extractor/nebula.py Outdated Show resolved Hide resolved
yt_dlp/extractor/nebula.py Outdated Show resolved Hide resolved
yt_dlp/extractor/nebula.py Outdated Show resolved Hide resolved
yt_dlp/extractor/nebula.py Outdated Show resolved Hide resolved
yt_dlp/extractor/nebula.py Outdated Show resolved Hide resolved
yt_dlp/extractor/nebula.py Outdated Show resolved Hide resolved
@bashonly bashonly added the pending-fixes PR has had changes requested label Nov 19, 2023
seproDev and others added 3 commits November 19, 2023 22:29
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@bashonly bashonly removed the pending-fixes PR has had changes requested label Nov 19, 2023
@bashonly bashonly merged commit 45d82be into yt-dlp:master Nov 20, 2023
15 checks passed
@seproDev seproDev deleted the nebula branch November 20, 2023 01:04
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Closes yt-dlp#4300, Closes yt-dlp#5814, Closes yt-dlp#7588, Closes yt-dlp#6334, Closes yt-dlp#6538
Authored by: elyse0, pukkandan, seproDev

Co-authored-by: Elyse <26639800+elyse0@users.noreply.github.com>
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-enhancement Feature request for some website
Projects
None yet
4 participants