New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extractor/twitcasting] Twitcasting Live webpage changed #8574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old `_search_regex` in TwitCastingLiveIE is no longer available.
bashonly
requested changes
Nov 13, 2023
bashonly
added
site-bug
Issue with a specific website
pending-fixes
PR has had changes requested
labels
Nov 13, 2023
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
bashonly
approved these changes
Nov 13, 2023
bashonly
added
pending-review
PR needs a review
and removed
pending-fixes
PR has had changes requested
pending-review
PR needs a review
labels
Nov 13, 2023
bashonly
requested changes
Nov 13, 2023
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
bashonly
approved these changes
Nov 15, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: JC-Chung
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
_search_regex
inTwitCastingLiveIE
is no longer available.IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
r'data-type="movie" data-id="(\d+)">'
,r'tw-sound-flag-open-link" data-id="(\d+)" style='
,r'(?s)(<span\s*class="tw-movie-thumbnail-badge"\s*data-status="live">\s*LIVE)'
andr'(?s)<a\s+class="tw-movie-thumbnail"\s*href="/[^/]+/movie/(?P<video_id>\d+)"\s*>.+?</a>'
now no available in webpage.Fixes #
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
馃 Generated by Copilot at 06c1eb6
Summary
馃悰馃毃馃摵
Improve live stream extraction and error handling for
twitcasting
extractor. Use HTML attributes instead of regexes to get stream status and id.Walkthrough
data-is-onlive
attribute to determine the live status of the user (link, link)UserNotLive
exception if the user is not live, instead of returning an empty playlist (link)data-movie-id
attribute as a possible source of the live ID (link)