Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/beatbump] Add new domain and update tests #8576

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

seproDev
Copy link
Collaborator

@seproDev seproDev commented Nov 14, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Site changed from beatbump.ml to beatbump.io, probably due to .ml returning to mali from Freenom.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 73643b0

Summary

🌐🎵🛠️

Improved BeatBump extractor to handle multiple domains and provide better metadata. Updated beatbump.py with new classes, tests, and warnings.

Walkthrough

  • Update the _VALID_URL regexes for both BeatBumpVideoIE and BeatBumpPlaylistIE classes to support the .ml and .io domains and the different playlist types (link, link)
  • Remove the uploader_url field from the test case for BeatBumpVideoIE, as it is not relevant for the extractor (link)
  • Add the channel_is_verified and heatmap fields to the test case for BeatBumpVideoIE, as they are new features of the yt-dlp extractor (link)
  • Add a new test case for the .io domain for BeatBumpVideoIE, with the only_matching flag set to True (link)
  • Update the track, uploader, uploader_id, modified_date, uploader_url, title, tags, channel_url, and channel_is_verified fields for the test cases for BeatBumpPlaylistIE, as they may differ from the YouTube values (link, link, link, link, link)
  • Add the expected_warnings field to the test cases for BeatBumpPlaylistIE, as the extractor may emit a warning message that YouTube Music is not directly supported (link, link, link)
  • Add a new test case for the .io domain for BeatBumpPlaylistIE, with the only_matching flag set to True (link)

@seproDev seproDev changed the title [it/beatbump] Add new domain and update tests [ie/beatbump] Add new domain and update tests Nov 14, 2023
@bashonly bashonly added the site-bug Issue with a specific website label Nov 14, 2023
@bashonly bashonly self-assigned this Nov 14, 2023
@bashonly bashonly merged commit 21dc069 into yt-dlp:master Nov 15, 2023
17 checks passed
@seproDev seproDev deleted the beatbump branch November 15, 2023 16:42
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants