New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving ThePlatform Metadata extraction #8635
Conversation
fixed up a scrippsnetworks test for the theplatform change
…r the life of me. If anyone can get it to work, feel free to return it fixed.
…ed a number of tests
# Conflicts: # yt_dlp/extractor/scrippsnetworks.py
And, unrelated to my review (out-of-scope for this PR):
I am thinking these multi-purpose extractors such as |
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
…only's suggestions Adding the media_type field in common. This has to be reviewed, as I don't know where else this has to be added.
…nto theplatform
…type field (possibly incomplete)
I've implemented the suggested changes and made some slight changes to them. |
Added the media_type field
My bad, that should have never made it into the PR. Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
I just noticed that the |
…nto theplatform # Conflicts: # yt_dlp/extractor/mediaset.py
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
…nto theplatform # Conflicts: # yt_dlp/extractor/cbc.py # yt_dlp/extractor/mediaset.py # yt_dlp/extractor/nbc.py
@seproDev I've updated everything I can - unfortunately, those tests are either geo-restricted, subscriber-only or broken. If anyone has access they can feel free to add them. |
I've pushed those changes myself |
Ignore the failing test. Pypy just randomly crashes sometimes |
I've merged everything together and addressed all the issues. Anything else? @pukkandan I've noticed Pypy crashing on my system occasionally as well. Is there any pattern that could be reported as an error (to Pypy devs)? |
Authored by: bashonly
Authored by: trainman261
Authored by: trainman261
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This improves metadata extraction for sites that use ThePlatform and updates the tests accordingly:
I have done the same level of regression testing as for my previous ThePlatformIE PR and have fixed all regression issues that appeared.
I am also now proposing to add the media_type field with this PR. This should be more carefully looked at, since I don't know much about the code outside of the extractor classes - I've tried to find where changes are needed but I only found the explanation in the common extractor class. Please add any other changes that may be necessary.
Fixes #
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?