Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pp/FFmpegMetadata] Embed stream metadata in single format downloads #8647

Merged
merged 1 commit into from Nov 26, 2023

Conversation

bashonly
Copy link
Member

Previously, stream metadata (e.g. language) was only being embedded in downloads that were merged video+audio. This patch will make it so the postprocessor also embeds stream metadata in single format downloads.

Closes #8568

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@bashonly bashonly added the bug Bug that is not site-specific label Nov 23, 2023
@Grub4K
Copy link
Member

Grub4K commented Nov 23, 2023

We should eventually refactor requested_formats to always have all requested formats, even if its only one. Lets leave it as is for now though

@bashonly bashonly merged commit deeb13e into yt-dlp:master Nov 26, 2023
15 checks passed
@bashonly bashonly deleted the fix/pp-embed-stream-meta branch December 7, 2023 15:08
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that is not site-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is yt-dlp setting the wrong language on the extracted audio track?
2 participants