Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RinseFM] - Add: Artist episodes playlist #8794

Merged
merged 7 commits into from Jan 19, 2024
Merged

Conversation

SirElderling
Copy link
Contributor

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

This PR extends the original extractor #8778 with the ability to extract all the episodes for a given artist as a playlist.

To keep it simple, the extraction of the episodes relies on the original RinseFMIE class.
As such, no additional error handling (ex. media not found; page not found) was added.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@bashonly bashonly self-requested a review December 18, 2023 19:06
@bashonly bashonly added the site-enhancement Feature request for some website label Dec 18, 2023
@seproDev
Copy link
Collaborator

seproDev commented Jan 7, 2024

Since the data on the show pages contains all the same data as extracted by RinseFMIE, I think it would be better to return the entries directly instead of using URL results.
For that, move the entry to info dict parsing code in to a base class. Use that function in both RinseFMIE and RinseFMArtistPlaylistIE.

For large playlists, this will be able to save a bunch of HTTP requests.

@seproDev seproDev added the pending-fixes PR has had changes requested label Jan 7, 2024
@SirElderling
Copy link
Contributor Author

Since the data on the show pages contains all the same data as extracted by RinseFMIE, I think it would be better to return the entries directly instead of using URL results. For that, move the entry to info dict parsing code in to a base class. Use that function in both RinseFMIE and RinseFMArtistPlaylistIE.

For large playlists, this will be able to save a bunch of HTTP requests.

Thanks for the suggestion. I adjusted the code to reflect this change.

yt_dlp/extractor/rinsefm.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rinsefm.py Outdated Show resolved Hide resolved
@bashonly bashonly removed the pending-fixes PR has had changes requested label Jan 14, 2024
@seproDev seproDev added the pending-review PR needs a review label Jan 14, 2024
yt_dlp/extractor/rinsefm.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rinsefm.py Outdated Show resolved Hide resolved
@bashonly bashonly removed the pending-review PR needs a review label Jan 19, 2024
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@seproDev seproDev merged commit 1a36dba into yt-dlp:master Jan 19, 2024
6 checks passed
@SirElderling SirElderling deleted the rinsefm branch January 24, 2024 08:59
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants