Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes #8810

Merged
merged 3 commits into from Dec 22, 2023
Merged

minor fixes #8810

merged 3 commits into from Dec 22, 2023

Conversation

barsnick
Copy link
Contributor

@barsnick barsnick commented Dec 20, 2023

Some minor fixes.

These should probably go into one of the regular clean-up commits.

Description of your pull request and other information

This fixes some extra whitespace in messages (probably introduced by stripping "`").

It also fixes use of IENAME, as inherited from youtube-dl. It was already wrong there, see the partial fix ytdl-org/youtube-dl@fc86d4e.

Note: flake8 yt_dlp/utils/_utils.py does not fail due to my changes.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@Grub4K
Copy link
Member

Grub4K commented Dec 20, 2023

The spaces are intentional, they are suppose to be the signifying code or links. Please revert

@barsnick
Copy link
Contributor Author

Please revert

Okay, reverted. (With a commit, since we're not supposed to force-push, right?)

@bashonly
Copy link
Member

Okay, reverted. (With a commit, since we're not supposed to force-push, right?)

yep, thank you!

@Grub4K Grub4K merged commit bc4ab17 into yt-dlp:master Dec 22, 2023
15 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants