Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test:networking] Update tests for OpenSSL 3.2 #8814

Merged
merged 1 commit into from Dec 20, 2023

Conversation

bashonly
Copy link
Member

OpenSSL 3.2 slightly tweaked its error messages which was causing some of our networking tests to fail:

FAILED test/test_networking.py::TestHTTPRequestHandler::test_ssl_error[Urllib] - AssertionError: Regex pattern did not match.
FAILED test/test_networking.py::TestHTTPRequestHandler::test_ssl_error[Requests] - AssertionError: Regex pattern did not match.
FAILED test/test_websockets.py::TestWebsSocketRequestHandlerConformance::test_ssl_error[Websockets] - AssertionError: Regex pattern did not match.

The new error message is:

[SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] ssl/tls alert handshake failure

vs. the old:

[SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure
Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@bashonly bashonly added docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc networking core networking related labels Dec 20, 2023
@bashonly bashonly merged commit 37755a0 into yt-dlp:master Dec 20, 2023
15 checks passed
@bashonly bashonly deleted the fix/openssl-tests branch December 21, 2023 20:38
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc networking core networking related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants