Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/twitter] Prioritize m3u8 formats #8826

Merged
merged 1 commit into from Dec 24, 2023

Conversation

bashonly
Copy link
Member

@bashonly bashonly commented Dec 21, 2023

Work around twitter's problematic http formats by prioritizing hls instead

Note that the approx bitrates for the http formats are wildly inaccurate, and are in fact the same as their equivalent resolution hls formats

Closes #8117

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@bashonly bashonly added the site-bug Issue with a specific website label Dec 21, 2023
@bashonly bashonly merged commit e7d2234 into yt-dlp:master Dec 24, 2023
15 checks passed
@bashonly bashonly deleted the fix/twitter-mp4 branch December 24, 2023 18:20
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Twitter/X videos download an mp4 that doesn't play in VLC but works after conversion through ffmpeg
2 participants