Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BiliBili] - Few adjustments to the BiliIntlIE class #8832

Merged
merged 7 commits into from Jan 19, 2024

Conversation

SirElderling
Copy link
Contributor

@SirElderling SirElderling commented Dec 22, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

This pull request contains a few adjustments to the BiliIntlIE class

WARNING: [BiliIntl] unable to extract JSON-LD ; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
WARNING: [BiliIntl] unable to extract og:title; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
WARNING: [BiliIntl] unable to extract og:description; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  • Removed a 404 test

  • Added timestamp and description extraction to the _parse_video_metadata function.

Note: I was unable to run many of the tests for the BiliIntlIE class due to geo block.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@seproDev seproDev added site-enhancement Feature request for some website site-bug Issue with a specific website labels Dec 22, 2023
@bashonly bashonly self-requested a review December 24, 2023 18:29
@seproDev
Copy link
Collaborator

The header changes are also part of #7077

@SirElderling
Copy link
Contributor Author

The header changes are also part of #7077

With the assumption that #7077 will be merged, should I remove the headers part from my PR?

@seproDev
Copy link
Collaborator

No need. I removed the header changes from #7077, so they are now only here.

yt_dlp/extractor/bilibili.py Outdated Show resolved Hide resolved
@bashonly bashonly added pending-review PR needs a review and removed pending-review PR needs a review labels Jan 19, 2024
@bashonly bashonly self-assigned this Jan 19, 2024
@SirElderling
Copy link
Contributor Author

The thumbnail property for the test'url': 'https://www.bilibili.tv/en/video/2045730385' sometimes returns akamaized.net instead of akamaized.com. I adjusted the test to reflect that.

yt_dlp/extractor/bilibili.py Outdated Show resolved Hide resolved
@bashonly bashonly merged commit 1713c88 into yt-dlp:master Jan 19, 2024
6 checks passed
@SirElderling SirElderling deleted the bilibilitv branch January 24, 2024 08:59
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants