Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9News] Add Extractor #8840

Merged
merged 8 commits into from Jan 19, 2024
Merged

[9News] Add Extractor #8840

merged 8 commits into from Jan 19, 2024

Conversation

SirElderling
Copy link
Contributor

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Initial video extractor for the 9News website.

Fixes #8831

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@seproDev seproDev added the site-request Request to support a new website label Dec 23, 2023
@seproDev
Copy link
Collaborator

I think you should just be able to use the Brightcove extractor:

return self.url_result(
    f'https://players.brightcove.net/{account}/default_default/index.html?videoId={video_id}',
    BrightcoveNewIE, video_id)

@SirElderling
Copy link
Contributor Author

SirElderling commented Dec 23, 2023

I think you should just be able to use the Brightcove extractor:

return self.url_result(
    f'https://players.brightcove.net/{account}/default_default/index.html?videoId={video_id}',
    BrightcoveNewIE, video_id)

Thank you very much for the tip. Adjusted the code to use BrightcoveNewIE as suggested.

yt_dlp/extractor/news9.py Outdated Show resolved Hide resolved
yt_dlp/extractor/news9.py Outdated Show resolved Hide resolved
yt_dlp/extractor/news9.py Outdated Show resolved Hide resolved
yt_dlp/extractor/news9.py Outdated Show resolved Hide resolved
yt_dlp/extractor/news9.py Outdated Show resolved Hide resolved
yt_dlp/extractor/news9.py Outdated Show resolved Hide resolved
@seproDev seproDev added the pending-review PR needs a review label Jan 4, 2024
yt_dlp/extractor/ninenews.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ninenews.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ninenews.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ninenews.py Outdated Show resolved Hide resolved
@bashonly bashonly removed the pending-review PR needs a review label Jan 19, 2024
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@seproDev seproDev merged commit 43694ce into yt-dlp:master Jan 19, 2024
6 checks passed
@SirElderling SirElderling deleted the 9news branch January 24, 2024 08:58
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9news.com.au site support
3 participants