[networking] Remove _CompatHTTPError

[coletdjnz]

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

_CompatHTTPError was to help with transition to the networking framework. It is not used in yt-dlp, but was there in the rare case plugins or external scripts were catching it.

These days it should be safe to remove. It just bloats the logs we get from users.

Be sure to add a breaking change announcement on the release changelog.

Template

Before submitting a pull request make sure you have:

• At least skimmed through contributing guidelines including yt-dlp coding conventions
• Searched the bugtracker for similar pull requests
• Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

• I am the original author of this code and I am willing to release it under Unlicense
• I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

• Fix or improvement to an extractor (Make sure to add/update tests)
• New extractor (Piracy websites will not be accepted)
• Core bug fix/improvement
• New feature (It is strongly recommended to open an issue first)

[pukkandan]

LGTM. But merge this for after the pending release imo

[pukkandan]

These days it should be safe to remove.

This is a very small change which nobody probably uses and so it's fine to remove.

But in general, I disagree. yt-dlp development moves very fast, but doesnt mean consumers of our API does the same. It's been only 3 months since deprecation, which is a tiny time window for more slow moving projects.

[pukkandan]

Shouldn't

yt-dlp/yt_dlp/compat/_legacy.py

Line 73 in 225cf2b

compat_HTTPError = urllib.error.HTTPError

also point to the new HTTPError?

[coletdjnz]

These days it should be safe to remove.

This is a very small change which nobody probably uses and so it's fine to remove.

But in general, I disagree. yt-dlp development moves very fast, but doesnt mean consumers of our API does the same. It's been only 3 months since deprecation, which is a tiny time window for more slow moving projects.

Yep, I agree too. Just in this particular case it should be fine as its unlikely to be used externally.

[pukkandan]

Missed

yt-dlp/yt_dlp/compat/_legacy.py

Line 91 in 225cf2b

compat_urllib_HTTPError = urllib.error.HTTPError

[coletdjnz]

Missed

yt-dlp/yt_dlp/compat/_legacy.py

Line 91 in 225cf2b

compat_urllib_HTTPError = urllib.error.HTTPError

that says explicitly urllib though?

[pukkandan]

They are supposed to be the same thing and was added due to ytdl-org/youtube-dl@249f2b6