[bugfix] Fix FireFox profile folder path for macOS #8909
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
I recently opened issue #8898 regarding
--cookies-from-browser firefox:<profile>
on macOS. When trying to find a Firefox profile on macOS, yt-dlp was looking in~/Library/Application Support/Firefox/
instead of the proper path,~/Library/Application Support/Firefox/Profiles/
.Firefox has used the
Profiles/
subdirectory to store profiles on macOS as far back as 2016 (and probably earlier than that, this was the first result in a Google search), so this is likely a bug on yt-dlp's part that has gone unreported.Fixes #8898
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?