Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix FireFox profile folder path for macOS #8909

Merged
merged 1 commit into from Jan 2, 2024

Conversation

RalphORama
Copy link
Contributor

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

I recently opened issue #8898 regarding --cookies-from-browser firefox:<profile> on macOS. When trying to find a Firefox profile on macOS, yt-dlp was looking in ~/Library/Application Support/Firefox/ instead of the proper path, ~/Library/Application Support/Firefox/Profiles/.

Firefox has used the Profiles/ subdirectory to store profiles on macOS as far back as 2016 (and probably earlier than that, this was the first result in a Google search), so this is likely a bug on yt-dlp's part that has gone unreported.

Fixes #8898

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@RalphORama RalphORama changed the title fix FireFox profile folder path for macOS [bugfix] Fix FireFox profile folder path for macOS Jan 1, 2024
@bashonly bashonly added the bug Bug that is not site-specific label Jan 1, 2024
@bashonly bashonly merged commit 85b33f5 into yt-dlp:master Jan 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that is not site-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[firefox/macOS] Using --cookies-from-browser firefox:<profile> throws FileNotFoundError
2 participants