Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[floatplane] feat: share playlist post fields with playlist entries #8934

Merged
merged 4 commits into from Jan 22, 2024

Conversation

chtk
Copy link
Contributor

@chtk chtk commented Jan 4, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Floatplane post can contain multiple items of video/audio, not just one. I'll call these playlist posts as opposed to regular posts

The extractor properly picks up all the entries in a playlist post. Downloading works fine. However some of the fields that would be available when downloading a regular post were not available for playlist entries.

I ran into this myself when I tried to use %(release_date)s in an output template.

This change:

  • collects common fields for the post entry and playlist entries ...
  • ... and spreads them in 1) the post info, and 2) every playlist entry
  • adds a test to verify.

Fixes #

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@seproDev seproDev added the site-bug Issue with a specific website label Jan 4, 2024
yt_dlp/extractor/floatplane.py Outdated Show resolved Hide resolved
yt_dlp/extractor/floatplane.py Outdated Show resolved Hide resolved
yt_dlp/extractor/floatplane.py Outdated Show resolved Hide resolved
yt_dlp/extractor/floatplane.py Outdated Show resolved Hide resolved
yt_dlp/extractor/floatplane.py Outdated Show resolved Hide resolved
yt_dlp/extractor/floatplane.py Outdated Show resolved Hide resolved
yt_dlp/extractor/floatplane.py Outdated Show resolved Hide resolved
@seproDev seproDev merged commit 9cd9044 into yt-dlp:master Jan 22, 2024
6 checks passed
@chtk chtk deleted the floatplane-playlist_posts branch January 22, 2024 06:01
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants