[NinaProtocol] Add extractor #8946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
seproDev
added
pending-review
|
A lot of the things your code did can be simplified by using functions from |
bashonly
approved these changes
Jan 31, 2024
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
FletcherD
pushed a commit
to FletcherD/yt-dlp
that referenced
this pull request
Feb 14, 2024
Closes yt-dlp#8709, Closes yt-dlp#8764 Authored by: RaduManole, seproDev Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#8709, Closes yt-dlp#8764 Authored by: RaduManole, seproDev Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Implementation of ninaprotocol.com extractor, worked on it some time ago, didn't see it already was PRed. You can use this code or not. I tried to make it fuzzy as possible, by capturing all JavaScript code, then searching the 'release' key in the json substring, and looking for the right 'release', by looking up the name of the album. Then I saw
#8764 (comment) and added it as a another try to find song data.
They treat songs as a release of an album. Individual songs are treated as an album with a single song. So, it doesn't matter if its one or multiple songs. I always treat the generic website link as a list of songs.
Fixes #8709
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?