Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/nhkradirulive] make station info non-fatal #8956

Merged
merged 1 commit into from Jan 8, 2024

Conversation

garret1317
Copy link
Collaborator

@garret1317 garret1317 commented Jan 8, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

R1 from Kanazawa is available as a temporary service due to the earthquake on the noto peninsula
https://www3.nhk.or.jp/netradio/kanazawa/
it only has the bare minimum to be playable - no station info, no nothing, just the stream url and the area name
it may be of interest to record, so this PR makes it so that the metadata download is non-fatal. everything past that is also non-fatal, so it all degrades reasonably gracefully

for an example do yt-dlp https://www.nhk.or.jp/radio/player/?ch=r1 --extractor-args nhkradirulive:area=kanazawa before/after this commit

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

R1 from Kanazawa is available as a temporary service due to the earthquake
on noto peninsula

it only has the bare minimum to be playable - no station info, no nothing,
just the stream url and the area name

it may be of interest to record, so this makes it so that the metadata
is non-fatal. everything past that is also non-fatal, so it all degrades
reasonably gracefully
@bashonly bashonly merged commit 5af1f19 into yt-dlp:master Jan 8, 2024
6 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants