Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/GoogleDrive] Update new Domain/URL for source file download #8990

Merged
merged 2 commits into from Jan 18, 2024

Conversation

jazz1611
Copy link
Contributor

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Fixes #8976 #

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Update new Domain/URL for source file download
@seproDev seproDev added the site-bug Issue with a specific website label Jan 13, 2024
@seproDev seproDev added the pending-fixes PR has had changes requested label Jan 14, 2024
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
@seproDev seproDev added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Jan 14, 2024
@jazz1611
Copy link
Contributor Author

Hello @seproDev

I tried building with this fix and it works stably. Can you apply to yt-dlp officially soon?

root@ubuntu:~# ./yt-dlp -Uv "https://drive.usercontent.google.com/download?id=0ByeS4oOUV-49Zzh4R1J6R09zazQ"
[debug] Command-line config: ['-Uv', 'https://drive.usercontent.google.com/download?id=0ByeS4oOUV-49Zzh4R1J6R09zazQ']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version stable@2023.12.30 from yt-dlp/yt-dlp [f10589e34] (linux_exe)
[debug] Python 3.10.12 (CPython x86_64 64bit) - Linux-5.15.0-91-generic-x86_64-with-glibc2.35 (OpenSSL 3.0.2 15 Mar 2022, glibc 2.35)
[debug] exe versions: ffmpeg 4.4.2 (setts), ffprobe 4.4.2
[debug] Optional libraries: Cryptodome-3.20.0, brotli-1.1.0, certifi-2023.11.17, mutagen-1.47.0, requests-2.31.0, secretstorage-3.3.1, sqlite3-3.37.2, urllib3-2.1.0, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1798 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: stable@2023.12.30 from yt-dlp/yt-dlp
yt-dlp is up to date (stable@2023.12.30 from yt-dlp/yt-dlp)
[GoogleDrive] Extracting URL: https://drive.usercontent.google.com/download?id=0ByeS4oOUV-49Zzh4R1J6R09zazQ
[GoogleDrive] 0ByeS4oOUV-49Zzh4R1J6R09zazQ: Downloading video webpage
[GoogleDrive] 0ByeS4oOUV-49Zzh4R1J6R09zazQ: Requesting source file
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] 0ByeS4oOUV-49Zzh4R1J6R09zazQ: Downloading 1 format(s): source
[debug] Invoking http downloader on "https://drive.usercontent.google.com/download?id=0ByeS4oOUV-49Zzh4R1J6R09zazQ&export=download&confirm=t"
[download] Destination: Big Buck Bunny.mp4 [0ByeS4oOUV-49Zzh4R1J6R09zazQ].mp4
[download] 100% of  177.36MiB in 00:00:11 at 15.97MiB/s

@seproDev
Copy link
Collaborator

@jazz1611 The extractor will need to be reviewed by another maintainer. Only after they also approve of the changes, can this be merged.

Copy link
Member

@pukkandan pukkandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you've run the extractor tests, LGTM

@bashonly bashonly removed the pending-review PR needs a review label Jan 18, 2024
@seproDev seproDev merged commit 5498729 into yt-dlp:master Jan 18, 2024
6 checks passed
@jazz1611 jazz1611 deleted the fix_googledrive_url branch March 14, 2024 15:39
@jazz1611 jazz1611 restored the fix_googledrive_url branch March 14, 2024 15:39
@jazz1611 jazz1611 deleted the fix_googledrive_url branch March 14, 2024 15:40
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Google Drive] cannot download file from source
4 participants