Fix GoPro extractor. #9019
Merged
Fix GoPro extractor. #9019
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pukkandan
requested changes
Jan 18, 2024
yt_dlp/extractor/gopro.py
Outdated
Comment on lines
62
to
64
| metadata = self._parse_json( | ||
| self._html_search_regex(r'window\.__reflectData\s*=\s*([^;]+)', webpage, 'metadata'), video_id) | ||
| self._search_regex(r'<script>window\.__reflectData\s*=\s*(.+)\s*;\s*</script>', | ||
| webpage, 'metadata'), video_id) |
There was a problem hiding this comment.
metadata = self._search_json(r'<script>window\.__reflectData\s*=', ...)should work better
yt_dlp/extractor/gopro.py
Outdated
Comment on lines
26
to
27
| 'track': '', | ||
| 'artist': '', |
There was a problem hiding this comment.
The track is not supposed to be an empty string. Extractor's returning wrong value. You don't have to fix the code in this PR, but don't add wrong value to test.
Suggested change
| 'track': '', | |
| 'artist': '', |
There was a problem hiding this comment.
Split the fix into a separate commit.
The extractor fails even when used on the URLs recorded in the tests with an error like: [GoPro] Extracting URL: https://gopro.com/v/KRm6Vgp2peg4e [GoPro] KRm6Vgp2peg4e: Downloading webpage ERROR: [GoPro] KRm6Vgp2peg4e: KRm6Vgp2peg4e: Failed to parse JSON (caused by JSONDecodeError('Expecting \',\' delimiter in \'"shop_url"=>"https:/\': line 1 column 5120 (char 5119)')); please report this issue on https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using yt-dlp -U File "/storage/avn/git/yt-dlp/yt_dlp/extractor/common.py", line 718, in extract ... - The JSON in the webpage now contains colons as part of HTML entities such as ". This makes the regexp used for matching truncate the JSON prematurely. - The same entities are replaced with the respective characters by clean_html, resulting in an invalid JSON. At the reviewer's suggestion, replaced _html_search_regex with _search_json to resolve both issues. Signed-off-by: Alexey Neyman <stilor@att.net>
gopro.com returns empty string as author/track for some videos; consider such attributes to be missing. Signed-off-by: Alexey Neyman <stilor@att.net>
seproDev
requested changes
Jan 18, 2024
yt_dlp/extractor/gopro.py
Outdated
Comment on lines
101
to
112
| 'artist': str_or_none( | ||
| 'artist': nonempty_or_none( | ||
| video_info.get('music_track_artist')), | ||
| 'track': str_or_none( | ||
| 'track': nonempty_or_none( | ||
| video_info.get('music_track_name')), |
There was a problem hiding this comment.
I would just do:
'artist': str_or_none(
video_info.get('music_track_artist')) or None,
'track': str_or_none(
video_info.get('music_track_name')) or None,Signed-off-by: Alexey Neyman <stilor@att.net>
seproDev
added
pending-review
bashonly
approved these changes
Jan 19, 2024
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: stilor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
The GoPro extractor fails even when used on the URLs recorded in the tests with an error like:
". This makes the regexp used for matching truncate the JSON prematurely.clean_html, resulting in an invalid JSON.authorandtrackfields in the returned dictionary.Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?