Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/facebook] update URL validation #9061

Merged
merged 1 commit into from Jan 28, 2024

Conversation

kclauhk
Copy link
Contributor

@kclauhk kclauhk commented Jan 24, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Update _VALID_URL for
https://www.facebook.com/permalink.php?story_fbid=< id >

It has almost the same structure as other, no other change is needed except validation.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@bashonly bashonly added the site-enhancement Feature request for some website label Jan 26, 2024
Copy link
Member

@bashonly bashonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for separating the PRs

@bashonly bashonly self-assigned this Jan 27, 2024
@bashonly bashonly merged commit 87286e9 into yt-dlp:master Jan 28, 2024
6 checks passed
@kclauhk kclauhk deleted the facebook/permalink branch January 29, 2024 15:37
FletcherD pushed a commit to FletcherD/yt-dlp that referenced this pull request Feb 14, 2024
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants