[ie/NYTimes] - Extractor overhaul - Article, Cooking Recipes and Guides #9075
Conversation
| 'skip_download': True, | ||
| }, | ||
| }, { | ||
| 'url': 'http://www.nytimes.com/news/minute/2014/03/17/times-minute-whats-next-in-crimea/?_php=true&_type=blogs&_php=true&_type=blogs&_r=1', |
There was a problem hiding this comment.
This URL still works too, although it redirects to https://archive.nytimes.com/www.nytimes.com/news/minute/2014/03/17/times-minute-whats-next-in-crimea/?_php=true&_php=true&_r=1&_type=blogs&_type=blogs
We'll probably need to add a new NYTimesArchive extractor for this, which can be a separate PR. Just noting it here so that it's not forgotten
There was a problem hiding this comment.
I'll take this into consideration in the next PR.
…GuidesIE based on code review
|
I made an edit to one of the review comments just now. Please make sure to work from the latest version of the comments before applying suggestions locally |
|
Side note: I'm using the 👍 in the comments to track the changes I applied in the local code. |
I believe I got everything. Thank you. |
|
It was trivial to (mostly) fix NYTimesIE with the code we already had, so I went ahead and did so. We are missing the timestamp/upload_date, though |
yt_dlp/extractor/nytimes.py
Outdated
| isLive | ||
| liveUrls |
There was a problem hiding this comment.
note: these may be useful in the future
playlists were not handled previously
original video IDs are still available for Guide but not for Recipe
Closes yt-dlp#2899, Closes yt-dlp#8605 Authored by: SirElderling
Closes yt-dlp#2899, Closes yt-dlp#8605 Authored by: SirElderling
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This is the first PR of my attempt to overhaul the existing, non working, extractor.
I'm pretty sure there is a lot to optimize on the code I'm submitting.
To try and facilitate the process, I decided to break all the adjustments I made in different PRs.
This first PR covers:
Fixes #8605 #2899
Future PRs will cover the extraction of:
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?