New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/zetland] Add ZetlandDKArticle Extractor #9116
Merged
bashonly
merged 14 commits into
yt-dlp:master
from
HobbyistDev:extractor/zetland-dk-issue-9024
Feb 2, 2024
Merged
[ie/zetland] Add ZetlandDKArticle Extractor #9116
bashonly
merged 14 commits into
yt-dlp:master
from
HobbyistDev:extractor/zetland-dk-issue-9024
Feb 2, 2024
+72
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashonly
requested changes
Jan 31, 2024
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
…HobbyistDev/yt-dlp into extractor/zetland-dk-issue-9024
bashonly
approved these changes
Feb 1, 2024
please double check the test since the branching and |
The test looks fine to me: > python devscripts/run_tests.py ZetlandDKArticleIE
Running ['pytest', '-Werror', '--tb=short', 'test/test_download.py::TestDownload::test_ZetlandDKArticle']
Running ['C:\\Users\\HobbyistDev\\Documents\\Program\\python_proj\\Scripts\\python.exe', '-Werror', '-m', 'unittest', 'test.test_download.TestDownload.test_ZetlandDKArticle']
[debug] Loaded 1825 extractors
[ZetlandDKArticle] Extracting URL: https://www.zetland.dk/historie/sO9aq2MY-a81VP3BY-66e69?utm_source=instagram&utm_medium=linkibio&utm_campaign=artikel
[ZetlandDKArticle] sO9aq2MY-a81VP3BY-66e69: Downloading webpage
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id
[info] sO9aq2MY-a81VP3BY-66e69: Downloading 1 format(s): 2
[info] Writing video metadata as JSON to: test_ZetlandDKArticle_sO9aq2MY-a81VP3BY-66e69.info.json
[debug] Invoking http downloader on "https://storage.googleapis.com/zetland-upload-production/07134420-b45f-11ee-b3a9-03589fc21889%2FJoannahusetafsnit1NYNYFINAL.mp3"
[debug] File locking is not supported. Proceeding without locking[download] Destination: test_ZetlandDKArticle_sO9aq2MY-a81VP3BY-66e69.mp3
[download] 100% of 10.00KiB in 00:00:02 at 4.65KiB/s
.
----------------------------------------------------------------------
Ran 1 test in 4.214s
OK |
seproDev
approved these changes
Feb 1, 2024
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
FletcherD
pushed a commit
to FletcherD/yt-dlp
that referenced
this pull request
Feb 14, 2024
Closes yt-dlp#9024 Authored by: HobbyistDev
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#9024 Authored by: HobbyistDev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This PR add site support for
zetland.dk
. This PR only test the OP url in #9024 as the other url require subscription. This PR only assume the article only contain 1 audio link with no other type of mediaFixes #9024
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?