Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/zetland] Add ZetlandDKArticle Extractor #9116

Merged
merged 14 commits into from Feb 2, 2024

Conversation

HobbyistDev
Copy link
Contributor

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

This PR add site support for zetland.dk. This PR only test the OP url in #9024 as the other url require subscription. This PR only assume the article only contain 1 audio link with no other type of media

Fixes #9024

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@bashonly bashonly added the site-request Request to support a new website label Jan 31, 2024
yt_dlp/extractor/zetland.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zetland.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zetland.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zetland.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zetland.py Outdated Show resolved Hide resolved
@bashonly bashonly added the pending-fixes PR has had changes requested label Jan 31, 2024
HobbyistDev and others added 8 commits February 1, 2024 08:21
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
yt_dlp/extractor/zetland.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zetland.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zetland.py Outdated Show resolved Hide resolved
@bashonly bashonly removed the pending-fixes PR has had changes requested label Feb 1, 2024
@bashonly bashonly self-assigned this Feb 1, 2024
@bashonly
Copy link
Member

bashonly commented Feb 1, 2024

please double check the test since the branching and description fixes may yield different results

@HobbyistDev
Copy link
Contributor Author

The test looks fine to me:

> python devscripts/run_tests.py ZetlandDKArticleIE
Running ['pytest', '-Werror', '--tb=short', 'test/test_download.py::TestDownload::test_ZetlandDKArticle']
Running ['C:\\Users\\HobbyistDev\\Documents\\Program\\python_proj\\Scripts\\python.exe', '-Werror', '-m', 'unittest', 'test.test_download.TestDownload.test_ZetlandDKArticle']
[debug] Loaded 1825 extractors 
[ZetlandDKArticle] Extracting URL: https://www.zetland.dk/historie/sO9aq2MY-a81VP3BY-66e69?utm_source=instagram&utm_medium=linkibio&utm_campaign=artikel
[ZetlandDKArticle] sO9aq2MY-a81VP3BY-66e69: Downloading webpage
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id
[info] sO9aq2MY-a81VP3BY-66e69: Downloading 1 format(s): 2
[info] Writing video metadata as JSON to: test_ZetlandDKArticle_sO9aq2MY-a81VP3BY-66e69.info.json 
[debug] Invoking http downloader on "https://storage.googleapis.com/zetland-upload-production/07134420-b45f-11ee-b3a9-03589fc21889%2FJoannahusetafsnit1NYNYFINAL.mp3"
[debug] File locking is not supported. Proceeding without locking[download] Destination: test_ZetlandDKArticle_sO9aq2MY-a81VP3BY-66e69.mp3 
[download] 100% of   10.00KiB in 00:00:02 at 4.65KiB/s 
.
----------------------------------------------------------------------
Ran 1 test in 4.214s

OK

yt_dlp/extractor/zetland.py Outdated Show resolved Hide resolved
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
@bashonly bashonly merged commit 2f4b575 into yt-dlp:master Feb 2, 2024
6 checks passed
FletcherD pushed a commit to FletcherD/yt-dlp that referenced this pull request Feb 14, 2024
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zetland.dk
3 participants