Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/TV5Monde] Fix extractor #9143

Merged
merged 8 commits into from
May 11, 2024
Merged

[ie/TV5Monde] Fix extractor #9143

merged 8 commits into from
May 11, 2024

Conversation

alard
Copy link
Contributor

@alard alard commented Feb 5, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

This updates the TV5MondePlusIE extractor for the new URL and HTML structure of tv5monde.com.

Fixes #9118

A few open questions:

  1. The new website does not seem to offer subtitles (at least I haven't found a video that uses them), so I have not been able to test if this part of the extractor still works.

  2. While the extractor is called TV5 Monde Plus, this fixes the behavior for tv5monde.com, which is a different website.

    In my region, tv5mondeplus.com redirects to tv5monde.com. Via a VPN I was able to access the plus version, which is a different website with a different structure. In the US it requires a subscription. As the page structure is different, I have my doubts that the current version of the extractor worked there. I have removed the tv5mondeplus.com URL from the extractor for now.

    Maybe the TV Monde Plus site needs its own custom extractor and this one should be renamed.

If anyone knows more about the location of the subtitles, or has experience with TV Monde Plus, feel free to comment.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@pukkandan pukkandan added geo-blocked Content is geo-blocked site-bug Issue with a specific website labels Feb 7, 2024
@alard alard changed the title [extractor/tv5monde] Update for new tvmonde.com website [extractor/tv5monde] Update for new tv5monde.com website Feb 12, 2024
@seproDev seproDev changed the title [extractor/tv5monde] Update for new tv5monde.com website [ie/TV5MondePlus] Fix extractor Mar 23, 2024
yt_dlp/extractor/tv5mondeplus.py Outdated Show resolved Hide resolved
yt_dlp/extractor/tv5mondeplus.py Outdated Show resolved Hide resolved
yt_dlp/extractor/tv5mondeplus.py Outdated Show resolved Hide resolved
yt_dlp/extractor/tv5mondeplus.py Outdated Show resolved Hide resolved
@seproDev seproDev added the pending-fixes PR has had changes requested label Mar 24, 2024
@alard
Copy link
Contributor Author

alard commented Apr 11, 2024

@seproDev Thanks for the review. I made the changes you suggested.

yt_dlp/extractor/tv5mondeplus.py Outdated Show resolved Hide resolved
yt_dlp/extractor/tv5mondeplus.py Outdated Show resolved Hide resolved
yt_dlp/extractor/tv5mondeplus.py Outdated Show resolved Hide resolved
@alard alard requested a review from seproDev May 3, 2024 16:13
@seproDev
Copy link
Collaborator

seproDev commented May 8, 2024

Sorry, I took so long to get back to you. I was kind of dreading taking another look at the site, as the way they expose their metadata is pretty ugly. I have pushed a rework of the metadata extraction. Please take a look and verify that this makes sense.
I am specifically unsure about the title/series/episode distinction, but this is the best I came up with.

@seproDev seproDev added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels May 8, 2024
@seproDev seproDev changed the title [ie/TV5MondePlus] Fix extractor [ie/TV5Monde] Fix extractor May 9, 2024
yt_dlp/extractor/tv5mondeplus.py Outdated Show resolved Hide resolved
@bashonly bashonly removed the pending-review PR needs a review label May 11, 2024
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@seproDev seproDev merged commit 6db9626 into yt-dlp:master May 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
geo-blocked Content is geo-blocked site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The site TV5MONDE has changed its name for Video Archive
4 participants