-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/TV5Monde] Fix extractor #9143
Conversation
@seproDev Thanks for the review. I made the changes you suggested. |
Sorry, I took so long to get back to you. I was kind of dreading taking another look at the site, as the way they expose their metadata is pretty ugly. I have pushed a rework of the metadata extraction. Please take a look and verify that this makes sense. |
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This updates the TV5MondePlusIE extractor for the new URL and HTML structure of tv5monde.com.
Fixes #9118
A few open questions:
The new website does not seem to offer subtitles (at least I haven't found a video that uses them), so I have not been able to test if this part of the extractor still works.
While the extractor is called TV5 Monde Plus, this fixes the behavior for
tv5monde.com
, which is a different website.In my region,
tv5mondeplus.com
redirects totv5monde.com
. Via a VPN I was able to access the plus version, which is a different website with a different structure. In the US it requires a subscription. As the page structure is different, I have my doubts that the current version of the extractor worked there. I have removed thetv5mondeplus.com
URL from the extractor for now.Maybe the TV Monde Plus site needs its own custom extractor and this one should be renamed.
If anyone knows more about the location of the subtitles, or has experience with TV Monde Plus, feel free to comment.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?