Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/NerdCubedFeed] Rework extractor #9269

Merged
merged 2 commits into from Feb 23, 2024
Merged

Conversation

seproDev
Copy link
Collaborator

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Fixes the extractor and makes it more useful by using the actual homepage as a URL instead of a random json.
The extractor wasn't outright removed due to potentially still being useful for reducing the number of API requests to YouTube and to have multiple channels combined.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@seproDev seproDev added the site-bug Issue with a specific website label Feb 22, 2024
@seproDev seproDev changed the title [ie/NerdCubedFeedIE] Rework extractor [ie/NerdCubedFeed] Rework extractor Feb 22, 2024
@seproDev seproDev added the pending-review PR needs a review label Feb 22, 2024
@pukkandan pukkandan removed the pending-review PR needs a review label Feb 23, 2024
@seproDev seproDev merged commit 29a74a6 into yt-dlp:master Feb 23, 2024
6 checks passed
@seproDev seproDev deleted the nercubed branch February 23, 2024 15:59
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants