Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dumpert] Broader url support #9320

Merged
merged 4 commits into from Mar 3, 2024
Merged

Conversation

rvsit
Copy link
Contributor

@rvsit rvsit commented Feb 29, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Now supports any url with ?selectedId= such as https://www.dumpert.nl/toppers/dag?selectedId=100086074_f5cef3ac

(Did not make issue because seem a fairly straightforward fix).
All tests run, see https://regex101.com/r/sXNP7f/1 to confirm that the regex still works properly for the other urls.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@bashonly bashonly added the site-bug Issue with a specific website label Mar 1, 2024
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
yt_dlp/extractor/dumpert.py Outdated Show resolved Hide resolved
yt_dlp/extractor/dumpert.py Outdated Show resolved Hide resolved
@bashonly bashonly added the pending-fixes PR has had changes requested label Mar 1, 2024
rvsit and others added 2 commits March 3, 2024 11:05
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@rvsit rvsit requested a review from bashonly March 3, 2024 16:05
@rvsit
Copy link
Contributor Author

rvsit commented Mar 3, 2024

Thanks for your comments, I agree with the changes.

@bashonly bashonly removed the pending-fixes PR has had changes requested label Mar 3, 2024
@bashonly bashonly self-assigned this Mar 3, 2024
@bashonly bashonly merged commit eedb38c into yt-dlp:master Mar 3, 2024
6 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants