Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test:websockets] Reduce timeout #9344

Merged
merged 2 commits into from Mar 4, 2024
Merged

Conversation

seproDev
Copy link
Collaborator

@seproDev seproDev commented Mar 3, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Seemingly, something got faster on Windows, causing the timeout tests to now (sometimes) fail. This PR reduces the timeout to ~2.2e-308 which is significantly shorter than the Planck time, so I think we should be good for a while.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@seproDev seproDev added the networking core networking related label Mar 3, 2024
@seproDev seproDev requested a review from coletdjnz March 3, 2024 02:15
test/test_websockets.py Outdated Show resolved Hide resolved
Copy link
Member

@coletdjnz coletdjnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this fixes it, LGTM

Alternative is to increase it to say 0.5s, but if we can make it quick the better.

@seproDev
Copy link
Collaborator Author

seproDev commented Mar 3, 2024

In my testing increasing the timeout the tests fail on both linux and windows due to the 101 switching protocol response arriving.

@bashonly bashonly assigned seproDev and unassigned coletdjnz Mar 4, 2024
@seproDev seproDev merged commit ac340d0 into yt-dlp:master Mar 4, 2024
15 checks passed
@seproDev seproDev deleted the websocket_timout branch March 4, 2024 16:47
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
networking core networking related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants