Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/francetv] Fix m3u8 formats extraction #9347

Merged
merged 5 commits into from Mar 3, 2024

Conversation

bashonly
Copy link
Member

@bashonly bashonly commented Mar 3, 2024

Per this comment by @boulderob, francetv's HLS formats are generally superior to their DASH formats, and were no longer being extracted after the API changes that were handled by 9749ac7.

This PR also does some much-needed cleanup: removing dead code paths (FranceTVIE hadn't been doing anything with all the catalog params being passed to it since 2021) and removing dead subdomains/hostnames (videos.francetv.fr, sivideo.webservices.francetelevisions.fr) from the URL regex patterns and tests.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

  • Fix or improvement to an extractor (Make sure to add/update tests)

@bashonly bashonly added the site-bug Issue with a specific website label Mar 3, 2024
bashonly referenced this pull request Mar 3, 2024
Closes #9323
Authored by: bashonly
@bashonly
Copy link
Member Author

bashonly commented Mar 3, 2024

I've made a pre-release for ease of testing, which exe/zip users can update to with this command:

yt-dlp --update-to bashonly/yt-dlp@francetv

@bashonly bashonly merged commit ede624d into yt-dlp:master Mar 3, 2024
6 checks passed
@boulderob
Copy link

Already merged but I can confirm that this is working for me also.

aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants