Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Misc (for 2024.04 release) #9426

Merged
merged 17 commits into from
Apr 9, 2024
Merged

Conversation

bashonly
Copy link
Member

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Cleanup commit(s) for the next release

@bashonly bashonly added the docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc label Mar 11, 2024
{
"action": "change",
"when": "e3a3ed8a981d9395c4859b6ef56cd02bc3148db2",
"short": "[cleanup:ie] No `from` stdlib imports in extractors",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure cleanup, ie is supposed to work 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, since they are different depths. Full form is misc/cleanup and extractor and different depths cannot be merged. Ive asked about this before and since no conflict resolving strategy was proposed I did not implement any

@Grub4K Grub4K marked this pull request as ready for review April 9, 2024 16:03
@bashonly bashonly merged commit 216f6a3 into yt-dlp:master Apr 9, 2024
15 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Authored by: bashonly, pukkandan
@bashonly bashonly deleted the cleanup/2024-04 branch May 10, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants