Add YouTube client for 1080p muxed videos #9546
Merged
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am opposed to adding this to the default list. Opinions? @bashonly @coletdjnz Also, make sure to document in readme |
This comment was marked as outdated.
This comment was marked as outdated.
|
|
|
I'm not too concerned about it being on by default or not, i just added it there while testing with vrchat to check the returned streams were compatible with avpro easily, as long as it can be enabled with a command line option I'm fine with it not being on by default. I'm also not too sure what the difference between base_clients vs defaults is as I'm unfamiliar with the codebase. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
|
"Wrong player response" issue has been confirmed to not be due to this PR and should be tracked separately |
|
You can also get the 1080p muxed videos by using a safari user agent with the web client, so could also add a duplicate of web client with the safari user agent.
|
coletdjnz
approved these changes
Mar 28, 2024
coletdjnz
requested changes
Mar 28, 2024
bashonly
reviewed
Mar 28, 2024
Co-authored-by: coletdjnz <coletdjnz@protonmail.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Interesting, is it the same streams as this returns? |
|
web client only, using safari UA: media connect frontend only: (no need to add safari web client version atm though, can use --user-agent for that) |
11 tasks
Hm.. I can't seem to reproduce this, Am I doing something wrong here? |
|
try |
Yep, works with that, thanks |
|
Is there a way to only impersonate safari for a specific extractor? |
|
there will be when #9474 is merged |
bashonly
approved these changes
Mar 29, 2024
MoojMidge
added a commit
to MoojMidge/plugin.video.youtube
that referenced
this pull request
Mar 30, 2024
- Possibly allows 1080p non-adaptive formats to be used - yt-dlp/yt-dlp#9546
bashonly
requested changes
Apr 3, 2024
yt_dlp/extractor/youtube.py
Outdated
| @@ -238,6 +238,16 @@ | |||
| }, | |||
| 'INNERTUBE_CONTEXT_CLIENT_NAME': 85 | |||
| }, | |||
| # This client has 1080p non split stream videos | |||
| 'media_connect_frontend': { | |||
There was a problem hiding this comment.
as pukkandan mentioned on discord, _ has special meaning in client names, so we need to change this to something like mediaconnect
bashonly
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your pull request and other information
Adds the ability for yt-dlp to return premuxed 1080p results for videos when available.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?