[ie/afreecatv] Fix extractor

[Tomoka1]

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

As in a somewhat reversal of #6283 this uses fully JSON again as some necessary information are not provided in XML any more.
This code will not keep XML part for backward compatibility.
The code is tested with login and without, on adult and regular.

Closes #4592, Closes #8862, Closes #9544

Template

Before submitting a pull request make sure you have:

• At least skimmed through contributing guidelines including yt-dlp coding conventions
• Searched the bugtracker for similar pull requests
• Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

• I am the original author of this code and I am willing to release it under Unlicense
• I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

• Fix or improvement to an extractor (Make sure to add/update tests)
• New extractor (Piracy websites will not be accepted)
• Core bug fix/improvement
• New feature (It is strongly recommended to open an issue first)

[zyz-1998]

still is problem : ERROR: [afreecatv] 109615861: 109615861: Failed to parse XML (caused by ParseError

[Tomoka1]

still is problem : ERROR: [afreecatv] 109615861: 109615861: Failed to parse XML (caused by ParseError

Are you sure you used the suggested changes? There shouldn't be anything to parse XML left.
Your example 109615861 works fine for me.

[zyz-1998]

I deployed yt_dlp using
C:\Users\ZYZ.conda\envs\python3.8\python.exe -m pip install --force-reinstall "yt-dlp[default] @ https://github.com/yt-dlp/yt- dlp/archive/master.tar.gz"

Is it because the latest package was not downloaded? Thank you.

[HobbyistDev]

I deployed yt_dlp using
C:\Users\ZYZ.conda\envs\python3.8\python.exe -m pip install --force-reinstall "yt-dlp[default] @ https://github.com/yt-dlp/yt-dlp/archive/master.tar.gz"
Is it because the latest package was not downloaded? Thank you.

I think you should get yt-dlp from Tomoka1's branch first (because it's not in main branch yet)

---

While the aim of the PR is not to extract XML file, i think it nice if we could extract the upload_date (and perhaps other key) like #8862

[zyz-1998]

What should be done, thank you

[zyz-1998]

new probelm ERROR: [afreecatv] 109615861: 109615861: HTTP Error 502: Bad Gateway (caused by <HTTPError 502: Bad Gateway>)

[Tomoka1]

HobbyistDev wrote:

While the aim of the PR is not to extract XML file, i think it nice if we could extract the upload_date (and perhaps other key) like #8862

I am not sure what you're referring to.
upload_date is retrieved from file_info_key as it was done before in similar fashion.
Using write_tm or broad_start wouldn't be an issue, if that's preferred.

[~]$ python -m yt_dlp https://vod.afreecatv.com/player/109615861 --print "%(upload_date)s %(title)s" 
20231116 [클립]생)사랑스런 민영이 오늘은 시스루~ 검스 ㅎ ㅏㅏㅏ ㅀ

---

zyz-1998 wrote:

new probelm ERROR: [afreecatv] 109615861: 109615861: HTTP Error 502: Bad Gateway (caused by <HTTPError 502: Bad Gateway>)

Not replicable on my side. I assume you're sitting in some geolocked region.
Try curl https://api.m.afreecatv.com/station/video/a/view and if it's negative please open another issue.

[bashonly]

Partial review

We don't need the for _ in range(2): loop at all anymore, right? IIRC it was used to re-fetch adult content by updating the query for the XML request. But we don't do that anymore.

Can you also update the tests and add an adult content test, since the current one is dead?

[bashonly]

I removed all the dead code and simplified/modernized what was left. Please test my changes and let me know what you think.

My previous review is no longer applicable except for this part:

Can you ... add an adult content test, since the current one is dead?

I've added an only_matching test for an adult content URL, it would be nice if you could test it / convert it into a proper test

[Tomoka1]

@bashonly Oh, i just wrote up-to-date tests myself before seeing the merge. Sorry i didn't have too much time this week. Thanks for your hard work!