Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/soundcloud] Adjust format sorting #9584

Merged
merged 2 commits into from Mar 31, 2024

Conversation

bashonly
Copy link
Member

@bashonly bashonly commented Mar 31, 2024

Adapts the soundcloud extractor's format sorting to the change in 86a9720

Before:

ID           EXT  RESOLUTION │  FILESIZE  TBR PROTO │ VCODEC     ACODEC   ABR
─────────────────────────────────────────────────────────────────────────────
hls_mp3_128  mp3  audio only │ ~ 5.99MiB 128k m3u8  │ audio only mp3     128k
http_mp3_128 mp3  audio only │ ~ 5.99MiB 128k http  │ audio only mp3     128k
hls_aac_256  aac  audio only │ ~11.99MiB 256k m3u8F │ audio only aac     256k
http_aac_256 aac  audio only │ ~11.99MiB 256k http  │ audio only aac     256k
hls_opus_64  opus audio only │ ~ 3.00MiB  64k m3u8  │ audio only opus     64k
download     wav  audio only │  64.54MiB      https │ audio only unknown

After:

ID           EXT  RESOLUTION │  FILESIZE  TBR PROTO │ VCODEC     ACODEC   ABR MORE INFO
─────────────────────────────────────────────────────────────────────────────────────────────
hls_mp3_128  mp3  audio only │ ~ 5.99MiB 128k m3u8  │ audio only mp3     128k
http_mp3_128 mp3  audio only │ ~ 5.99MiB 128k http  │ audio only mp3     128k
hls_opus_64  opus audio only │ ~ 3.00MiB  64k m3u8  │ audio only opus     64k
hls_aac_256  aac  audio only │ ~11.99MiB 256k m3u8F │ audio only aac     256k Premium
http_aac_256 aac  audio only │ ~11.99MiB 256k http  │ audio only aac     256k Premium
download     wav  audio only │  64.54MiB      https │ audio only unknown      Original
Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

  • Fix or improvement to an extractor (Make sure to add/update tests)

@bashonly bashonly added the site-bug Issue with a specific website label Mar 31, 2024
Authored by: bashonly
@bashonly bashonly merged commit a2d0840 into yt-dlp:master Mar 31, 2024
6 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant