[ie/orf:on] Improve extraction #9677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TuxCoder
force-pushed
the
on_orf_at_more_parsing
branch
from
68ae87a
to
e3192e8
Compare
added 2 commits
April 12, 2024 23:14
use the linked subtitles in the v4.3 api
some urls are without slug also some video-Id's are shorter that 8 digits and could probably be bigger than 8
TuxCoder
force-pushed
the
on_orf_at_more_parsing
branch
from
e3192e8
to
f51d16b
Compare
seproDev
added
site-enhancement
seproDev
requested changes
May 19, 2024
seproDev
reviewed
May 19, 2024
added 4 commits
May 20, 2024 13:15
some videos formats were not reported as DRM protected fixes: yt-dlp#9652
new test file has no kill_date, so I hope it will be online for longer old one will be not available after "2024-08-12T21:05:00+02:00"
as display_id is optional it does not make sense to keep it
TuxCoder
force-pushed
the
on_orf_at_more_parsing
branch
from
f51d16b
to
c30f9fc
Compare
|
Please do not force push. All commits will be squashed upon merge, and it makes reviewing harder. |
|
thanks for the Feedback, try to add the changes and rerun the tests. Force Push, |
seproDev
reviewed
May 20, 2024
|
Thanks again for the good feedback. I'm not sure about the subtitles as I not wanted to break Otherwise should be good now. |
seproDev
changed the title
seproDev
reviewed
May 20, 2024
added 2 commits
May 20, 2024 14:51
interrate over all subtitles and sort that `vtt` is default, so `--embed-subs` is working out of the box
as `vtt_url` is the last in the list, it will get priority
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
seproDev
approved these changes
May 20, 2024
seproDev
added
pending-review
Grub4K
approved these changes
May 22, 2024
bashonly
approved these changes
May 22, 2024
Jhordan1376
approved these changes
May 23, 2024
Jhordan1376
approved these changes
May 23, 2024
Jhordan1376
approved these changes
May 23, 2024
Jhordan1376
approved these changes
May 23, 2024
seproDev
reviewed
May 23, 2024
|
Thanks again for the nice Review! I got today motivated to publish my documentation for the API Feel free to us it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
example for 7 digits: https://on.orf.at/video/3229173
the new test data has
killdate: Noneas attribute, so this should be more stable for the futuresadly I did't found any video with age restriction and
right: "worldwide"only with restriction to Austria and/or with akilldate< 2025, IMHO not worth to add as will create future problemTemplate
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Open Questions:
'xml', 'srt', 'sami', 'ttml', 'stl'that are available so I comment them outdisplay_idbe remove?! as it is not included with all urls fromon.orf.atAs this is my first PR to
yt-dlpI hope I didn't oversaw anything from the good written guidelines.If so feel free to point that out.