[ie/crunchyroll] Fix auth and remove cookies support #9749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authored by: bashonly
pukkandan
reviewed
Apr 21, 2024
yt_dlp/extractor/crunchyroll.py
Outdated
| @@ -42,70 +46,73 @@ class CrunchyrollBaseIE(InfoExtractor): | |||
| 'ru': 'ru-RU', | |||
| 'hi': 'hi-IN', | |||
| } | |||
| _CF_HINT = 'Request blocked by Cloudflare; navigate to Crunchyroll in your browser, then pass the fresh cookies (with --cookies-from-browser or --cookies) and your browser\'s User-Agent (with --user-agent)' | |||
There was a problem hiding this comment.
I thought curl-cffi works for crunchyroll, no?
There was a problem hiding this comment.
It does, but since using the cookies/user-agent bypass method is now commonplace among our users, and since curl-cffi is only available in 2 of our builds, I think it would be a regression to remove this hint and only rely on the impersonate API warning.
I think we should utilize the impersonate API in this extractor after #9756 is merged, so that the extractor can determine how to handle the 403 error based on whether or not impersonation was used for the request.
Also, if it wasn't clear in the PR description, the 403 error that this PR fixes is completely unrelated to cloudflare/impersonation
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Grub4K
approved these changes
Apr 21, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CR is requiring Switch-specific auth tokens now for the Switch stream info API endpoint that the extractor uses.
This makes auth via the website useless and breaks our cookies support.
--username+--passwordand--netrcstill work, and using no auth still works for free content.Closes #9745
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?