Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CGTN] Add new extractor #981

Merged
merged 6 commits into from
Sep 19, 2021
Merged

[CGTN] Add new extractor #981

merged 6 commits into from
Sep 19, 2021

Conversation

chao813
Copy link
Contributor

@chao813 chao813 commented Sep 15, 2021

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

@chao813
Copy link
Contributor Author

chao813 commented Sep 16, 2021

@Ashish0804 should this be pending review?

@Ashish0804 Ashish0804 added the pending-review PR needs a review label Sep 16, 2021
@Ashish0804
Copy link
Contributor

Actually everything else looks fine, I'm just not sure if the timestamp extraction can be handled using an function from utils
I'll mark this as pending-review so someone else knows to take a look at aswell.

@chao813
Copy link
Contributor Author

chao813 commented Sep 16, 2021

@Ashish0804 thanks! The timestamp extraction is working using the unified_timestamp function from utils, its passing the test cases.

yt_dlp/extractor/cgtn.py Outdated Show resolved Hide resolved
yt_dlp/extractor/cgtn.py Outdated Show resolved Hide resolved
@pukkandan pukkandan added pending-fixes PR has had changes requested and removed pending-review PR needs a review labels Sep 16, 2021
@pukkandan pukkandan removed the pending-fixes PR has had changes requested label Sep 19, 2021
@pukkandan pukkandan merged commit a63d9bd into yt-dlp:master Sep 19, 2021
nixxo pushed a commit to nixxo/yt-dlp that referenced this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants