-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/XVideosQuickies] Fix extractor #9834
Conversation
Forgot to update title field in test
Pls add tests for each. |
btw, is there any way to get the old numeric id of a video? |
Implements suggested change from pukkandan Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
This adds 2 additional tests _(for: profiles/, amateur-channels/)_, and it also fixes the first test which was incorrect... I had ran the test incorrectly so I thought it was passing, but now it is passing correctly.
Seems that the old numeric IDs still work with the old URL format. Since the old numeric IDs no longer show up on the website it would probably be safe to remove them from the extractor, but it wasn't a lot of additional code to add support for them.
It does seem that you can still use the old video ID for downloading the videos, but the URL format must be the old one apparently... e.g. I went ahead and added support for the old numeric IDs as well, I'm not sure if it's implemented in a way that follows yt-dlp's standards, but it works and the old test passes as well. Also the video in the old test has an updated ID now in their system, so I'm guessing they completely swapped out their IDs (old test video ID: |
What is the status on getting this merged? Is there something blocking this getting merged? |
Commit suggested change from pukkandan Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
I didn't catch that the conditional check got reversed by the suggested change from Pukkandan. This fixes that regression.
Alright the code has been updated to use |
LGTM 👍 |
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
XVideos changed their quickies URL format, as such the extractor needs to be updated. The code has been checked using flake8 and the test has been updated and passes.
This pull request introduces the following modifications:
https://www.xvideos.com/video.QUICKIES_ID/_
.profiles/
,amateur-channels/
).Example valid URLs with this fix:
https://www.xvideos.com/lili_love#quickies/a/ipdtikh1a4c
https://www.xvideos.com/profiles/lili_love#quickies/a/ipdtikh1a4c
https://www.xvideos.com/amateur-channels/lili_love#quickies/a/ipdtikh1a4c
Fixes #6356
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?