Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/vk] Improve format extraction #9885

Merged
merged 3 commits into from
May 8, 2024
Merged

Conversation

seproDev
Copy link
Collaborator

@seproDev seproDev commented May 8, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Sets the extension for http videos to mp4. While we can't be 100% sure that this will be the case for every video, I still think this is vastly preferable to unknown_video. Currently, all videos I checked are served as MP4s.
I've also added dash format extraction. This video contains vp9 and av1 dash formats.

Fixes #5675

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@seproDev seproDev added site-enhancement Feature request for some website site-bug Issue with a specific website labels May 8, 2024
@seproDev seproDev merged commit df5c9e7 into yt-dlp:master May 8, 2024
6 checks passed
@seproDev seproDev deleted the vk-unknown-video branch May 8, 2024 21:02
@seproDev seproDev removed their assignment May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VK Video] unknown_video extension while downloading some VK video playlists
3 participants