Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/cda] Fix age restriction #9939

Merged
merged 4 commits into from
May 16, 2024
Merged

Conversation

Podiumnoche
Copy link
Contributor

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Update to PR #6638

This pull request updates age confirmation to work with the new form. The code is as it was proposed by @emqi, the original poster of #5980.

Looks like https://github.com/Szpachlarz is not active, so I updated it according to #6638 (comment). I hope it's ready to merge, write me if anything more requires to be updated.

Fixes #5980

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@Podiumnoche
Copy link
Contributor Author

@selfisekai could you take a look?

@selfisekai
Copy link
Contributor

LGTM

Copy link
Member

@bashonly bashonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: when merging, remember to close original PR along with the issue, and credit the original PR author as well as the issue author

yt_dlp/extractor/cda.py Outdated Show resolved Hide resolved
yt_dlp/extractor/cda.py Outdated Show resolved Hide resolved
yt_dlp/extractor/cda.py Outdated Show resolved Hide resolved
@bashonly bashonly added site-bug Issue with a specific website pending-fixes PR has had changes requested labels May 16, 2024
@Podiumnoche Podiumnoche requested a review from bashonly May 16, 2024 21:24
@bashonly bashonly removed the pending-fixes PR has had changes requested label May 16, 2024
@bashonly bashonly self-assigned this May 16, 2024
@bashonly bashonly merged commit 6d8a53d into yt-dlp:master May 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CDA] Unable to download age restricted videos
3 participants