Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[postprocessor/EmbedThumbnail,postprocessor/FFmpegMetadata] Fix potential error on attaching thumbnails and info json for mkv/mka #6647

Merged
merged 2 commits into from Mar 27, 2023
Merged

[postprocessor/EmbedThumbnail,postprocessor/FFmpegMetadata] Fix potential error on attaching thumbnails and info json for mkv/mka #6647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
639a658
[postprocessor/EmbedThumbnail,postprocessor/FFmpegMetadata] Fix poten…
Lesmiscore Mar 27, 2023
4c2fdf7
use _ffmpeg_filename_argument
Lesmiscore Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion yt_dlp/postprocessor/embedthumbnail.py
View file
Open in desktop
Expand Up @@ -107,7 +107,7 @@ def run(self, info):
options.extend(['-map', '-0:%d' % old_stream])
new_stream -= 1
options.extend([
'-attach', thumbnail_filename,
'-attach', self._ffmpeg_filename_argument(thumbnail_filename),
'-metadata:s:%d' % new_stream, 'mimetype=%s' % mimetype,
'-metadata:s:%d' % new_stream, 'filename=cover.%s' % thumbnail_ext])

Expand Down
2 changes: 1 addition & 1 deletion yt_dlp/postprocessor/ffmpeg.py
View file
Open in desktop
Expand Up @@ -809,7 +809,7 @@ def _get_infojson_opts(self, info, infofn):
new_stream -= 1

yield (
'-attach', infofn,
'-attach', self._ffmpeg_filename_argument(infofn),
f'-metadata:s:{new_stream}', 'mimetype=application/json',
f'-metadata:s:{new_stream}', 'filename=info.json',
)
Expand Down