Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extractor/Funker530] fix: funker530 rumble embed link extraction and video download #8040

Merged
merged 3 commits into from Sep 16, 2023
Merged

[extractor/Funker530] fix: funker530 rumble embed link extraction and video download #8040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a52904
fixed funker530 rumble embed link extraction and video download
04-pasha-04 Sep 6, 2023
7a6203a
instead of doing the rumble embed link extraction inside the funker e…
04-pasha-04 Sep 10, 2023
d6b8177
Update yt_dlp/extractor/funker530.py
bashonly Sep 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions yt_dlp/extractor/funker530.py
View file
Open in desktop
Expand Up @@ -60,6 +60,7 @@ class Funker530IE(InfoExtractor):
def _real_extract(self, url):
display_id = self._match_id(url)
webpage = self._download_webpage(url, display_id)
info = {}
rumble_url = list(RumbleEmbedIE._extract_embed_urls(url, webpage))
if rumble_url:
info = {'url': rumble_url[0], 'ie_key': RumbleEmbedIE.ie_key()}
Expand Down
2 changes: 1 addition & 1 deletion yt_dlp/extractor/rumble.py
View file
Open in desktop
Expand Up @@ -144,7 +144,7 @@ def _extract_embed_urls(cls, url, webpage):
if embeds:
return embeds
return [f'https://rumble.com/embed/{mobj.group("id")}' for mobj in re.finditer(
r'<script>[^<]*\bRumble\(\s*"play"\s*,\s*{\s*[\'"]?video[\'"]?\s*:\s*[\'"](?P<id>[0-9a-z]+)[\'"]', webpage)]
r'<script>[^<]*\bRumble\(\s*"play"\s*,\s*{[^}]*[\'"]?video[\'"]?\s*:\s*[\'"](?P<id>[0-9a-z]+)[\'"]', webpage)]

def _real_extract(self, url):
video_id = self._match_id(url)
Expand Down