Add US customary units kip and ksi #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the force unit kip, also referred to as the kilopound or kilopound-force (kipf). Equals 1000 lbf. Adds ksi, kips per square inch. Equals 1000 psi.
|
|
|
Updated with tests. I put them in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the force unit kip (a.k.a. kipf or kilopound, 1000 lbf) and the pressure unit ksi (kips per square inch, 1000 psi). These are most commonly used in architecture and engineering. I'm following
pintin making the default name kip refer to a force unit.I'm a little confused on tests -- some are in
test_units.pyand some are intest_unyt_array.py. Is there a preferred place for tests for units?