New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: harmonize rules for how NEP 18 functions handle an out argument #295

Merged

ngoldbaum merged 1 commit into yt-project:main from neutrinoceros:nep18_harmonize_out

Oct 14, 2022

Member

neutrinoceros commented Oct 13, 2022

follow up to #293
Apply rules established in #200:

the out argument is only valid if it's a unyt_array with an appropriate unit (convertible to the expected return unit)
if its unit doesn't match the "natural" one (say if we concatenate two arrays with units "cm", but we out to a third array with units "km"), convert it in place


          ENH: harmonize rules for how NEP 18 functions handle an *out* argument

fb2f749

neutrinoceros mentioned this pull request

NEP 18 progress tracker #289

Closed

neutrinoceros marked this pull request as ready for review

October 13, 2022 19:22

ngoldbaum merged commit c34c211 into yt-project:main

neutrinoceros deleted the nep18_harmonize_out branch

October 14, 2022 19:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment