TST: adapt a test to numpy 2.0 (NEP 50) #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
hotfix_nep50
branch
from
68a4878
to
e364332
Compare
neutrinoceros
force-pushed
the
hotfix_nep50
branch
from
e364332
to
8434c15
Compare
|
Now that I've had time to actually read NEP 50, I'm confident this is the correct approach. Opening for review. |
|
@jzuhone can we merge this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes tests with bleeding-edge numpy. I'm relatively confident this is the correct fix, but I want to come back to it later when I have more time to double check, so, opening as a draft for now.