make MKS <-> CGS conversions smarter, add Farad. Fixes #53 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a few other things in here beyond what you said (some doc changes/fixes)--they look ok to me but should they be mentioned in the description for posterity? |
|
Sorry, I had to push some extraneous stuff to fix the coverage tests. |
|
No worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue pointed out by @l-johnston in #53. For units that are made up of base units we can be a little bit smarter. I've also added a test.
I've also added Farad to the default unit registry since I believe that was omitted as an oversight and not because of any intentional reason.
Edit: Also pushed some minor doc fixes to unbreak the coverage tests.