New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate docs out of pylab #3395

Closed

neutrinoceros opened this issue Jun 30, 2021 · 0 comments · Fixed by #3412

Labels

docs

Milestone

Member

neutrinoceros commented Jun 30, 2021

Bug report

Bug summary

Despite PR #3144 and PR #3225, pylab is still being used in some of the documentation.
using pylab is officially discouraged by matplotlib and considered bad practice in the Python ecosystem
https://matplotlib.org/stable/api/index.html?highlight=pylab#module-pylab

This should not be blocking for the 4.0 release, but I really would like this to go away once and for all after that.

todo :

refactor remaining bits of pylab in the docs
maybe add a pre-commit hook or a GitHub workflow to prevent this from coming back.

neutrinoceros added the docs label

neutrinoceros added this to the 4.1.0 milestone

neutrinoceros mentioned this issue

DOC: cleanup remaining occurences of pylab in favour of matplotlib.pyplot #3412

Merged

neutrinoceros closed this as completed in #3412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment