maint: use matplotlib.pyplot in examples instead of matplotlib.pylab #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I honestly had no idea we were using pylab anywhere!
…On Wed, Mar 24, 2021 at 11:27 AM Clément Robert ***@***.***> wrote:
PR Summary
https://matplotlib.org/2.0.2/faq/usage_faq.html#matplotlib-pyplot-and-pylab-how-are-they-related
matplotlib.pylab is a wrapper that contains matplotlib.pyplot and numpy.
The reason it exists was to help people migrating from Matlab to Python,
but its usage is discouraged, so I'm replacing it with direct calls to
pyplot in our documentation and docstrings.
------------------------------
You can view, comment on, or merge this pull request online at:
#3144
Commit Summary
- maint: use matplotlib.pyplot in examples instead of matplotlib.pylab
File Changes
- *M* doc/source/cookbook/streamlines.py
<https://github.com/yt-project/yt/pull/3144/files#diff-fc13dd580c87a4fca62eb3ddafb04af5dbbecb6529c26caa42b27653078dfa76>
(6)
- *M* doc/source/cookbook/streamlines_isocontour.py
<https://github.com/yt-project/yt/pull/3144/files#diff-237a25f045652eb1e88753e7a7150058dbf7c82673bc907993b5da6dd2b0a52c>
(6)
- *M* doc/source/visualizing/streamlines.rst
<https://github.com/yt-project/yt/pull/3144/files#diff-14e6b42f8b4664edc88feb8956953822f8b2594418af210d4cd7be637275d6fa>
(6)
- *M* yt/data_objects/particle_trajectories.py
<https://github.com/yt-project/yt/pull/3144/files#diff-2fff9e1e24e11ea82ada041af9596af953f328d08e809919e3629878dea85ba8>
(6)
- *M* yt/visualization/streamlines.py
<https://github.com/yt-project/yt/pull/3144/files#diff-25ec183db62751d28e98c2bf08f6848060eeb493e86c2f5a66e3a5d381501dd4>
(6)
Patch Links:
- https://github.com/yt-project/yt/pull/3144.patch
- https://github.com/yt-project/yt/pull/3144.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3144>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVXO4YUV6VOFSPH7NHDFLTFIHGFANCNFSM4ZXTMZUQ>
.
|
|
I discovered this using pydeps |
munkm
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
See https://matplotlib.org/2.0.2/faq/usage_faq.html#matplotlib-pyplot-and-pylab-how-are-they-related
TLDR:
matplotlib.pylabis a wrapper that containsmatplotlib.pyplotandnumpy. The reason it exists was to help people migrating from Matlab to Python, but its usage is discouraged, so I'm replacing it with direct calls to pyplot in our documentation and docstrings.