Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: build shouldn't succeed if an error is raised in a notebook or script #3502

Open
neutrinoceros opened this issue Sep 6, 2021 · 0 comments
Labels
docs enhancement Making something better infrastructure Related to CI, versioning, websites, organizational issues, etc

Comments

@neutrinoceros
Copy link
Member

Bug report

Bug summary

As recently shown by #3500 (and I believe on several occasions before that), our infrastructure currently allows for "passing" documentation builds even when errors are raised in notebooks.
There should be a way to fix this so we can't solve issues when they are introduced instead of when they are manually reported.

In a sense, this is complementary to #3369, but probably more crucial.
Since #3369 is currently in the 4.1 milestone I'll put this one in too, in hopes that it can at least be discussed in a foreseeable future, though it should never be considered blocking, and could easily be postponed if necessary.

@neutrinoceros neutrinoceros added enhancement Making something better infrastructure Related to CI, versioning, websites, organizational issues, etc labels Sep 6, 2021
@neutrinoceros neutrinoceros added this to the 4.1.0 milestone Sep 6, 2021
@neutrinoceros neutrinoceros removed this from the 4.1.0 milestone Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs enhancement Making something better infrastructure Related to CI, versioning, websites, organizational issues, etc
Projects
None yet
Development

No branches or pull requests

1 participant