Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAMSES inaccurate Mpc to cm conversion value #3867

Closed
lconaboy opened this issue Mar 29, 2022 · 0 comments · Fixed by #3868
Closed

RAMSES inaccurate Mpc to cm conversion value #3867

lconaboy opened this issue Mar 29, 2022 · 0 comments · Fixed by #3868
Labels
bug code frontends Things related to specific frontends
Milestone
4.0.3

Comments

@lconaboy
Copy link
Contributor

Bug report

Bug summary

The RAMSES frontend uses the value 3.08e24 to convert from Mpc to cm when determining the current (proper) simulation time. This is probably a hangover from when the value 3.08e24 was widely used in RAMSES itself, but modern versions of the code use the more accurate 3.0856776d+24, which agrees with cm_per_mpc defined in yt/utilities/physical_ratios.py.

Originally mentioned in #3864 and might affect #2098.

Version Information

  • Operating System: Ubuntu 18.04
  • Python Version: 3.8.5 (Anaconda)
  • yt version: 4.1.dev0 (from source)
lconaboy added a commit to lconaboy/yt that referenced this issue Mar 29, 2022
@lconaboy
Use cm_per_mpc instead of 3.08e24 yt-project#3867
07bc7e7
@lconaboy lconaboy mentioned this issue Mar 29, 2022
Merged
@neutrinoceros neutrinoceros linked a pull request Mar 29, 2022 that will close this issue
BUG: Use cm_per_mpc instead of 3.08e24 #3867 #3868
Merged
@neutrinoceros neutrinoceros added bug code frontends Things related to specific frontends labels Mar 29, 2022
@cphyc cphyc added this to the 4.0.3 milestone Mar 29, 2022
cphyc added a commit that referenced this issue Mar 31, 2022
@cphyc
Merge pull request #3868 from lconaboy/update-ramses-mpc
a6b3b8b 
BUG: Use cm_per_mpc instead of 3.08e24 #3867
meeseeksmachine pushed a commit to meeseeksmachine/yt that referenced this issue Mar 31, 2022
@cphyc @meeseeksmachine
Backport PR yt-project#3868: BUG: Use cm_per_mpc instead of 3.08e24 y…
59ab080 
…t-project#3867
@meeseeksmachine meeseeksmachine mentioned this issue Mar 31, 2022
Merged
neutrinoceros added a commit that referenced this issue Mar 31, 2022
@neutrinoceros
Merge pull request #3877 from meeseeksmachine/auto-backport-of-pr-386…
da27553 
…8-on-yt-4.0.x

Backport PR #3868 on branch yt-4.0.x (BUG: Use cm_per_mpc instead of 3.08e24 #3867)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug code frontends Things related to specific frontends
Projects
None yet
Milestone
4.0.3
Development

Successfully merging a pull request may close this issue.

BUG: Use cm_per_mpc instead of 3.08e24 #3867 lconaboy/yt
3 participants
@cphyc @neutrinoceros @lconaboy