Remove unused kdtree and parallel components from grid_traversal.pyx #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sort of -1 on removing the kdtree, as I believe that others (perhaps @chummels ) may want to re-enable star rendering in the future, and it is the simplest way toward that. However, I'm not going to hold up the PR with that. |
|
By the time that happens we should either have a new dependency on |
jzuhone
approved these changes
Jun 7, 2017
lindsayad
approved these changes
Jun 8, 2017
matthewturk
pushed a commit
to matthewturk/yt
that referenced
this pull request
Apr 17, 2018
Remove unused kdtree and parallel components from grid_traversal.pyx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
grid_traversal.pyxwas cimporting functions incython.parallelbut not actually using them. This means this file doesn't need to be compiled with OpenMP support.While fixing that, I noticed that we were also using code from this
kdtree_utilswrapper for a C KDTree implementation. It turns out, as far as I can see, the C kdtree we include here is only used for a stub feature (something related to rendering star particles, i think?) in the old volume rendering interface. Given that this feature is in deprecated code and we are planning to include a much more featureful C++ kdtree in the future, I think we should remove this C KDTree. This also means we're no longer shipping a big hunk of C code that none of us wrote.