Add support for Enzo MHDCT fields #1438
Conversation
| direction, but nodal in the other two, i.e. it lives on the four cell edges that | ||
| are normal to the z direction. | ||
|
|
||
| ..code-block:: python |
There was a problem hiding this comment.
There should be a space between .. and code-block. Also empty line right afterwards. Could you also fix the WarpX snippet while you're at it?
| .. code-block:: python | ||
|
|
||
| ad = ds.all_data() | ||
| print(ds.field_info[('enzo', 'Ex')].nodal_flag) |
There was a problem hiding this comment.
I'm not sure if it's really important but if do just import, load, all_data the index won't be created at this point and it will fail with AttributeError.
There was a problem hiding this comment.
Interesting, I thought ds.all_data() created the index.
yt/utilities/io_handler.py
Outdated
| if selector.__class__.__name__ == "GridSelector": | ||
| if data is None: | ||
| continue | ||
| if selector.__class__ is GridSelector and field not in nodal_fields: |
There was a problem hiding this comment.
Why not isinstance(selector, GridSelector) ?
yt/frontends/enzo/io.py
Outdated
| nodal_flag = self.ds.field_info[field].nodal_flag | ||
| dims = obj.ActiveDimensions[::-1].copy() | ||
| if np.any(nodal_flag): | ||
| dims += nodal_flag[::-1] |
There was a problem hiding this comment.
Since nodal_flag is [0,0,0] by default, can we do that unconditionally?
|
This looks good, but the way the nodal flags are set inside a try/except for KeyError (which contains two possible KeyErrors) feels a bit awkward. I'd prefer to supply a default value and skip the t/e. |
ngoldbaum
force-pushed
the
enzo-mhdct-fields
branch
from
a610fe2
to
1dfce75
Compare
ngoldbaum
force-pushed
the
enzo-mhdct-fields
branch
from
1dfce75
to
9f56cfe
Compare
Add support for Enzo MHDCT fields
This adds support for Enzo MHDCT fields, following the support @atmyers added for nodal WarpX data.
The implementation is relatively straightforward. I just needed to add support for I/O on these fields following more or less what the boxlib frontend does. I also needed to teach the enzo frontend which fields are expected to be nodal and what their expected nodal flags are. In principle we could read these data off disk like the boxlib frotend does but as far as I'm aware that data is currently not written out by Enzo so it needs to be hardcoded in the Enzo frontend.
While working on this I noticed a pattern where we do something like:
many places in the codebase. Since this is arcane and wordy, I decided to globally replace it with
which is a bit less arcane. Let me know if you'd prefer to have that change as a separate pull request.